Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sponsoredCount-prop #593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add sponsoredCount-prop #593

wants to merge 1 commit into from

Conversation

hiagolcm
Copy link
Contributor

What problem is this solving?

Currently, the maximum number of sponsoredProducts is hardcoded. This PR allows the developer to change it via store-theme. For example:

"store.search": {
    "blocks": ["search-result-layout"],
    "props": {
      "context": {
        "sponsoredCount": 4
      }
    }
  },

It also removes the sponsoredProductsBehavior which is a deprecated prop.

How to test it?

Workspace

Related to / Depends on

vtex-apps/search-result#691

@hiagolcm hiagolcm requested a review from a team as a code owner November 29, 2024 13:00
@hiagolcm hiagolcm requested review from vsseixaso, RodrigoTadeuF and leo-prange-vtex and removed request for a team November 29, 2024 13:00
@vtex-io-ci-cd VTEX IO CI/CD
Copy link
Contributor

vtex-io-ci-cd bot commented Nov 29, 2024 •
edited by hiagolcm
Loading

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Nov 29, 2024 •
edited by hiagolcm
Loading

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@hiagolcm hiagolcm mentioned this pull request Nov 29, 2024
Open
@hiagolcm hiagolcm force-pushed the feature/sponsoredCount-prop branch from 99ff7a7 to 5d5b67e Compare November 29, 2024 13:10
@hiagolcm hiagolcm force-pushed the feature/sponsoredCount-prop branch from 5d5b67e to 92b613c Compare November 29, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salesfelipe salesfelipe salesfelipe approved these changes

@vsseixaso vsseixaso Awaiting requested review from vsseixaso vsseixaso is a code owner automatically assigned from vtex-apps/store-framework-devs

@RodrigoTadeuF RodrigoTadeuF Awaiting requested review from RodrigoTadeuF RodrigoTadeuF is a code owner automatically assigned from vtex-apps/store-framework-devs

@leo-prange-vtex leo-prange-vtex Awaiting requested review from leo-prange-vtex leo-prange-vtex is a code owner automatically assigned from vtex-apps/store-framework-devs

@ArthurFerrao ArthurFerrao Awaiting requested review from ArthurFerrao

@luarakerlen luarakerlen Awaiting requested review from luarakerlen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiagolcm @salesfelipe